Adopt --code-font-family#6997
Merged
ludeeus merged 20 commits intohome-assistant:devfrom Sep 21, 2020
Merged
Conversation
Member
|
You can skip some places by adding it to |
Contributor
Author
|
How could I do that? |
Member
|
Contributor
Author
|
Thanks for the tip. Now how can I remove redundant code? |
Member
|
The same way you added it? |
Contributor
Author
|
I don't want to remove it in places where it's actually needed. Just curious if you had some guidance. |
Contributor
Author
|
Manually looked through all files, couldn't find any places where I could skip it. |
ludeeus
reviewed
Sep 15, 2020
ludeeus
reviewed
Sep 16, 2020
src/panels/config/integrations/integration-panels/zwave/zwave-log-dialog.js
Outdated
Show resolved
Hide resolved
ludeeus
approved these changes
Sep 21, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This makes more cards use the new
--code-font-familyvariable for their<pre>tags.Type of change
Kinda both... The feature isn't new, I've added this for the code editor before, so it fixes the bug of partial adoption, but it could also be that it's making the new feature complete.
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: