Merged
Conversation
bramkragten
reviewed
Sep 21, 2020
bramkragten
reviewed
Sep 21, 2020
| }); | ||
|
|
||
| this._config = config; | ||
| this._config = { initial_view: "dayGridMonth", ...config }; |
Member
There was a problem hiding this comment.
The default already is dayGridMonth, so this is not needed?
Contributor
Author
There was a problem hiding this comment.
Well, if this._config.initialView is undefined then we set it on the calendar as undefined. The property default gets overridden by Undefined. ifDefined directive is only for attributes I believe (or I didn't set it up correctly) so the default here is needed unless there is another way I have missed (which I am sure there is)
|
@zsarnett really looking forward to get this merged! |
Member
Please just add a thumbs-up reaction for things like this. Now everyone is pinged. |
bramkragten
approved these changes
Sep 25, 2020
Merged
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: