Skip to content

Make moon icon more readable#6969

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
KTibow:patch-5
Sep 13, 2020
Merged

Make moon icon more readable#6969
bramkragten merged 1 commit intohome-assistant:devfrom
KTibow:patch-5

Conversation

@KTibow
Copy link
Copy Markdown
Contributor

@KTibow KTibow commented Sep 13, 2020

Proposed change

Increase the saturation value of the moon icon, so it has more contrast with white.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Probably there are lots of snippets of the moon icon being that color, but it'd be too hard to update all of them.

@zsarnett
Copy link
Copy Markdown
Contributor

Can you add an image of the comparisons?

@KTibow
Copy link
Copy Markdown
Contributor Author

KTibow commented Sep 13, 2020

Previous:
image
After:
image
Still not as yellow as the sun icon:
image

@zsarnett
Copy link
Copy Markdown
Contributor

I'm going to tag this for .115.

@zsarnett zsarnett added this to the 0.115.0 milestone Sep 13, 2020
@bramkragten bramkragten merged commit 9af805a into home-assistant:dev Sep 13, 2020
@KTibow KTibow deleted the patch-5 branch September 15, 2020 01:44
@bramkragten bramkragten mentioned this pull request Sep 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weather card: moon icon has no contrast with default theme

4 participants