Skip to content

Add default hold actions#6952

Merged
ludeeus merged 1 commit intodevfrom
default-hold-actions
Sep 12, 2020
Merged

Add default hold actions#6952
ludeeus merged 1 commit intodevfrom
default-hold-actions

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Fixes #6942

Proposed change

We never checked for the hasHold action in the action handler, meaning every element would have a hold action, and when no action was defined we would use the more-info action.

I fixed that we didn't check the hasHold action, and not all the element that didn't specify a default hold action would no longer have a hold action.

This PR adds a default hold action for a lot of elements, not sure I got them all though...

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus merged commit 90e09fc into dev Sep 12, 2020
@ludeeus ludeeus deleted the default-hold-actions branch September 12, 2020 16:07
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hold_action no longer defaults to more-info

3 participants