Skip to content

Add last_updated tooltip to more info dialog #6926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 6 commits into from
Sep 29, 2020
Merged

Add last_updated tooltip to more info dialog #6926

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f59379a
add last_updated field to more-person-info dialog
pszafer Sep 11, 2020
53a30c4
create div except inject
pszafer Sep 11, 2020
568daf6
add tooltip to state-info
pszafer Sep 12, 2020
a7f7afd
use paper-tooltip
pszafer Sep 12, 2020
85a6ef5
add id to ha-relative-time
pszafer Sep 13, 2020
f7b5523
rename to last_changed
pszafer Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/components/entity/state-info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { html } from "@polymer/polymer/lib/utils/html-tag";
import "@polymer/paper-tooltip/paper-tooltip";
/* eslint-plugin-disable lit */
import { PolymerElement } from "@polymer/polymer/polymer-element";
import { computeStateName } from "../../common/entity/compute_state_name";
Expand Down Expand Up @@ -74,10 +75,19 @@ class StateInfo extends PolymerElement {

<template is="dom-if" if="[[inDialog]]">
<div class="time-ago">
<ha-relative-time
hass="[[hass]]"
datetime="[[stateObj.last_changed]]"
></ha-relative-time>
<span>
Comment thread
pszafer marked this conversation as resolved.
Outdated
<ha-relative-time
hass="[[hass]]"
datetime="[[stateObj.last_changed]]"
></ha-relative-time>
<paper-tooltip animation-delay="0">
[[localize('ui.dialogs.more_info_control.last_updated')]]:

@bramkragten bramkragten Sep 12, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string doesn't exist yet? You have to add it to src/translations/en.json

@pszafer pszafer Sep 13, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added. one notice, even if string is added it doesn't show in my browser. Actually it doesn't show even if I use some other string like ui.dialogs.more_info_control.dismiss.

<ha-relative-time
hass="[[hass]]"
datetime="[[stateObj.last_updated]]"
></ha-relative-time>
</paper-tooltip>
</span>
</div>
</template>
<template is="dom-if" if="[[!inDialog]]">
Expand Down