Skip to content

Only show history tabs for certain domains#6895

Merged
bramkragten merged 3 commits intodevfrom
more-info-history-tab
Sep 9, 2020
Merged

Only show history tabs for certain domains#6895
bramkragten merged 3 commits intodevfrom
more-info-history-tab

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

<mwc-tab
.label=${this.hass.localize(
"ui.dialogs.more_info_control.controls"
"ui.dialogs.more_info_control.details"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not just details though... But I guess this works :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine until we change the names of entities 😉 then I think we should change it to match what they are.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we could make it Entity for now until we change the naming

Co-authored-by: Zack Barett <arnett.zackary@gmail.com>
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming things sucks :)

@bramkragten bramkragten merged commit e0bdef9 into dev Sep 9, 2020
@bramkragten bramkragten deleted the more-info-history-tab branch September 9, 2020 20:10
@bramkragten bramkragten mentioned this pull request Sep 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dont show history tab in more info for read-only entities More info "Controls" tab naming

4 participants