Skip to content

Color all deletion options consistenly red#6891

Merged
ludeeus merged 5 commits intohome-assistant:devfrom
spacegaier:delete-warnings
Sep 9, 2020
Merged

Color all deletion options consistenly red#6891
ludeeus merged 5 commits intohome-assistant:devfrom
spacegaier:delete-warnings

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Sep 9, 2020

Breaking change

Proposed change

In the existing dialogs the delete option is always colored red. To create consistency this PR does:

  1. Colors the deletion icon for automations, scenes, scripts red
  2. Adjusts the color for the automation action row from yellow to red (was red for almost all instances already before but one)
  3. Color the "Remove Selected" entity config button (fixes Remove Selected button on Entities panel not red #6892)

image

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett
Copy link
Copy Markdown
Contributor

zsarnett commented Sep 9, 2020

#6892

Can you get this as well

@spacegaier
Copy link
Copy Markdown
Member Author

#6892

Can you get this as well

@zsarnett Done.

@spacegaier spacegaier requested a review from ludeeus September 9, 2020 18:29
@ludeeus ludeeus merged commit 1890aab into home-assistant:dev Sep 9, 2020
@spacegaier spacegaier deleted the delete-warnings branch September 9, 2020 18:53
@bramkragten bramkragten mentioned this pull request Sep 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Selected button on Entities panel not red

4 participants