Skip to content

Add fallback for renderExternalStepHeader#6878

Merged
bramkragten merged 2 commits intodevfrom
external-header-fallback
Sep 9, 2020
Merged

Add fallback for renderExternalStepHeader#6878
bramkragten merged 2 commits intodevfrom
external-header-fallback

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Sep 9, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added this to the 0.115.0 milestone Sep 9, 2020
@zsarnett
Copy link
Copy Markdown
Contributor

zsarnett commented Sep 9, 2020

how does this fix the overlapping

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Sep 9, 2020

By actually producing content in the header

@zsarnett
Copy link
Copy Markdown
Contributor

zsarnett commented Sep 9, 2020

OHHHH That was the text not the header that is in that issue :)

Got it

@bramkragten bramkragten merged commit ad84300 into dev Sep 9, 2020
@bramkragten bramkragten deleted the external-header-fallback branch September 9, 2020 15:02
@bramkragten bramkragten mentioned this pull request Sep 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config flows - external website dialog issue (0.115.0b1)

4 participants