Skip to content

Remove mobile_app from generated Lovelace #6873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 7 commits into from
Sep 9, 2020
Merged

Remove mobile_app from generated Lovelace #6873

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cf2bcb4
Hide mobile_app from generated Lovelace
ludeeus Sep 9, 2020
a6c2483
simplify
ludeeus Sep 9, 2020
9e906bd
Move to computeDefaultViewStates
ludeeus Sep 9, 2020
d08db17
removed -> hidden
ludeeus Sep 9, 2020
e20b966
Update src/panels/lovelace/common/generate-lovelace-config.ts
ludeeus Sep 9, 2020
3741de0
Adjust for Set
ludeeus Sep 9, 2020
0af813b
Review comments
ludeeus Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/panels/lovelace/common/generate-lovelace-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ const HIDE_DOMAIN = new Set([
"zone",
]);

const HIDE_PLATFORM = new Set(["mobile_app"]);

let subscribedRegistries = false;

interface SplittedByAreas {
Expand Down Expand Up @@ -206,11 +208,21 @@ export const computeCards = (
return cards;
};

const computeDefaultViewStates = (entities: HassEntities): HassEntities => {
const computeDefaultViewStates = (
entities: HassEntities,
entityEntries: EntityRegistryEntry[]
): HassEntities => {
const states = {};
const hiddenEntities = entityEntries
.filter((entry) => HIDE_PLATFORM.includes(entry.platform))
Comment thread
ludeeus marked this conversation as resolved.
Outdated
.map((entry) => entry.entity_id);
Comment thread
ludeeus marked this conversation as resolved.
Outdated

Object.keys(entities).forEach((entityId) => {
const stateObj = entities[entityId];
if (!HIDE_DOMAIN.has(computeStateDomain(stateObj))) {
if (
!HIDE_DOMAIN.has(computeStateDomain(stateObj)) &&
!hiddenEntities.includes(entityId)
Comment thread
ludeeus marked this conversation as resolved.
Outdated
) {
states[entityId] = entities[entityId];
}
});
Expand Down Expand Up @@ -317,7 +329,7 @@ export const generateDefaultViewConfig = (
entities: HassEntities,
localize: LocalizeFunc
): LovelaceViewConfig => {
const states = computeDefaultViewStates(entities);
const states = computeDefaultViewStates(entities, entityEntries);
const path = "default_view";
const title = "Home";
const icon = undefined;
Expand Down