Skip to content

Media player visual improvements#6817

Merged
zsarnett merged 8 commits intohome-assistant:devfrom
spacegaier:media-player
Sep 8, 2020
Merged

Media player visual improvements#6817
zsarnett merged 8 commits intohome-assistant:devfrom
spacegaier:media-player

Conversation

@spacegaier
Copy link
Copy Markdown
Member

@spacegaier spacegaier commented Sep 7, 2020

Breaking change

Proposed change

  1. Added a bit of space between media icon and its title
    image

  2. Added tooltip to opening button of media player selection
    image

3. Improved visuals if no media items were found (list with "No items" as text). Previously it was just a pure text without any styling. (already tackled via #6813)
image

  1. Make media player selection dialog close on outside klick and Escape key press.

  2. Make media play dialog close on outside klick and Escape key press (fixes Escape key to dismiss Media Browser dialog #6839).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier changed the title Media player improvements Media player visual improvements Sep 7, 2020
@bramkragten
Copy link
Copy Markdown
Member

Please add a screenshot when making visual changes

@spacegaier
Copy link
Copy Markdown
Member Author

spacegaier commented Sep 7, 2020

Please add a screenshot when making visual changes

@bramkragten Added to the PR description.

@zsarnett
Copy link
Copy Markdown
Contributor

zsarnett commented Sep 7, 2020

This will now need to be rebased

@spacegaier
Copy link
Copy Markdown
Member Author

@zsarnett Rebase is done.

spacegaier and others added 2 commits September 8, 2020 18:01
@bramkragten bramkragten added this to the 0.115.0 milestone Sep 8, 2020
@zsarnett zsarnett merged commit 7c5a78a into home-assistant:dev Sep 8, 2020
@spacegaier spacegaier deleted the media-player branch September 8, 2020 22:00
@bramkragten bramkragten mentioned this pull request Sep 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Escape key to dismiss Media Browser dialog

6 participants