Media player visual improvements#6817
Merged
zsarnett merged 8 commits intohome-assistant:devfrom Sep 8, 2020
Merged
Conversation
Member
|
Please add a screenshot when making visual changes |
Member
Author
@bramkragten Added to the PR description. |
Contributor
|
This will now need to be rebased |
0a8ebb3 to
20294e0
Compare
Member
Author
|
@zsarnett Rebase is done. |
bramkragten
reviewed
Sep 8, 2020
bramkragten
reviewed
Sep 8, 2020
bramkragten
reviewed
Sep 8, 2020
bramkragten
reviewed
Sep 8, 2020
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
zsarnett
reviewed
Sep 8, 2020
bramkragten
approved these changes
Sep 8, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Added a bit of space between media icon and its title

Added tooltip to opening button of media player selection

3. Improved visuals if no media items were found (list with "No items" as text). Previously it was just a pure text without any styling.(already tackled via #6813)Make media player selection dialog close on outside klick and Escape key press.
Make media play dialog close on outside klick and Escape key press (fixes Escape key to dismiss Media Browser dialog #6839).
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: