Skip to content

Don't show source select dialog when media player Unavailable.#6799

Merged
zsarnett merged 1 commit intohome-assistant:devfrom
pszafer:media_player_source_select
Sep 5, 2020
Merged

Don't show source select dialog when media player Unavailable.#6799
zsarnett merged 1 commit intohome-assistant:devfrom
pszafer:media_player_source_select

Conversation

@pszafer
Copy link
Copy Markdown
Contributor

@pszafer pszafer commented Sep 5, 2020

Proposed change

Now select_source is disabled only in 'off' state.
It should be disabled for unavailable and unknown as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

None

Additional information

Whole change is just checking !["off", "unavailable"].includes(stateObj.state)

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett merged commit 8f8a2ce into home-assistant:dev Sep 5, 2020
@bramkragten bramkragten mentioned this pull request Sep 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants