Handle connection drops when upgrading#6767
Conversation
|
|
||
| protected firstUpdated(changedProps) { | ||
| super.firstUpdated(changedProps); | ||
| this._postUpdateDialog(); |
There was a problem hiding this comment.
Is there a good event that can be listened on here?
Currently, if the user now refreshes while doing the upgrade this will trigger, I guess that is fine.
I tried listening to the connection -> ready event, but that fires too early, the dialogs would not show.
There was a problem hiding this comment.
It will also trigger when I navigated away during the download/update and come back a week later, that is weird I think?
There was a problem hiding this comment.
If we want to go this way, we should store a time or something to make sure it only shows right after the update
There was a problem hiding this comment.
And if I updated in the meantime to a version higher it will say my update failed
There was a problem hiding this comment.
All true, which is why I asked about a event
There was a problem hiding this comment.
The event will not fix it if the user is not at this page when it is fired?
There was a problem hiding this comment.
No matter how we do this, it will be some weird situations.
I'll take this part out of the PR, and we can implement something (if needed) when something for home-assistant/supervisor#1946 is in place.
ludeeus
changed the title
3 participants
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: