Skip to content

Entities Card: Add Header & Footer Editor#6751

Merged
bramkragten merged 71 commits intodevfrom
footer-ui-config
Nov 9, 2020
Merged

Entities Card: Add Header & Footer Editor#6751
bramkragten merged 71 commits intodevfrom
footer-ui-config

Conversation

@zsarnett
Copy link
Contributor

@zsarnett zsarnett commented Aug 31, 2020

Proposed change

7b005160e3f9732255c31b4e747283b3

Type of change

  • New feature (thank you!)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: TODO

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett marked this pull request as draft August 31, 2020 00:36
@zsarnett zsarnett marked this pull request as ready for review August 31, 2020 14:55
@bramkragten
Copy link
Member

Thinking out loud here:

We are going to get action editors, row editors (+ entity detail editor), and then we have a separate tab for the header and footer.

Should we do the header and footer the same way?
Do we have a mockup of how the complete picture will look?

@zsarnett
Copy link
Contributor Author

The problem is putting too much on one Tab. Header and footer (while maybe Advanced is a bad tab name) aren't something that will be on every card.

Maybe we rename the tab to Extra or something 🤷‍♂️

We should not muddy up the row UI with more and more options that arent used in every card.

Same with the sensor card. Extra tab with the primary color field

@zsarnett
Copy link
Contributor Author

But also, no I dont have a mock up. My mockups are made by CSS and HTML. I am somewhat dumb when it comes to editing software. idk why. Honestly I don't have a good finalized idea of how I want the entity detail editor and special row "adder" to look like yet. I am building them in steps, hence the other special row pr

@zsarnett zsarnett marked this pull request as draft September 24, 2020 20:30
@zsarnett
Copy link
Contributor Author

I think I will come back to this once I have finalized the other editor for entities. So that everything is the same way

@SeanPM5
Copy link
Contributor

SeanPM5 commented Sep 24, 2020

Honestly I don't have a good finalized idea of how I want the entity detail editor and special row "adder" to look like yet.

For adding special rows, my idea was to have it inside the Entity dropdowns themselves. So at the very top of the dropdown would be something like this (special row name + descriptive text):

image

And then under those, in the same dropdown list, would be all your entities just like today. This would eliminate the need for another button or tab to add special rows. I had a bunch more mockups for this but can't find them anymore.

@zsarnett zsarnett marked this pull request as ready for review October 19, 2020 23:19
@zsarnett
Copy link
Contributor Author

Gif in the OP has been updated to reflect changes

Kind of
@zsarnett
Copy link
Contributor Author

I don't think I understand the T typing...

@bramkragten
Copy link
Member

I don't think I understand the T typing...

OK, ask me on discord if you're ready

@bramkragten bramkragten merged commit 32ff166 into dev Nov 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the footer-ui-config branch November 9, 2020 21:42
KTibow pushed a commit to KTibow/frontend-1 that referenced this pull request Nov 10, 2020
KTibow added a commit to KTibow/frontend-1 that referenced this pull request Nov 10, 2020
@bramkragten bramkragten mentioned this pull request Nov 11, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants