Conversation
|
I think we should split |
|
I agree this is pretty crowded. Would you like me to do that in this PR or different one? |
|
This PR please |
| if (this._params!.entities && this._params!.entities.length) { | ||
| if (Object.keys(config).includes("entities")) { | ||
| config.entities = this._params!.entities; | ||
| } else if (Object.keys(config).includes("entity")) { | ||
| config.entity = this._params!.entities[0]; | ||
| } | ||
| } |
There was a problem hiding this comment.
Isn't this logic in the edit card dialog? As it is also used for the suggest card?
There was a problem hiding this comment.
I dont know what you mean by this
There was a problem hiding this comment.
You can just add entities to the options of showEditCardDialog.
There was a problem hiding this comment.
Oh wait... create-card-dialog will open suggest-card-dialog and that will open create-card-dialog again and this logic kicks in?
There was a problem hiding this comment.
But I don't see that in the code now, suggest card will open dialog-edit-card? Does it even work now?
src/panels/lovelace/editor/card-editor/show-create-card-dialog.ts
Outdated
Show resolved
Hide resolved
src/panels/lovelace/editor/card-editor/show-create-card-dialog.ts
Outdated
Show resolved
Hide resolved
src/panels/lovelace/editor/card-editor/hui-entity-picker-table.ts
Outdated
Show resolved
Hide resolved
src/panels/lovelace/editor/card-editor/hui-dialog-create-card.ts
Outdated
Show resolved
Hide resolved
src/panels/lovelace/editor/card-editor/hui-dialog-create-card.ts
Outdated
Show resolved
Hide resolved
3 participants
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: