Skip to content

Add humidifier entity row#6213

Merged
bramkragten merged 6 commits intohome-assistant:devfrom
Shulyaka:humidifier_row
Sep 24, 2020
Merged

Add humidifier entity row#6213
bramkragten merged 6 commits intohome-assistant:devfrom
Shulyaka:humidifier_row

Conversation

@Shulyaka
Copy link
Contributor

Proposed change

Add entity row for humidifier devices.

entities

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

entities:
  - entity: humidifier.humidifier
  - entity: humidifier.dehumidifier
  - entity: humidifier.hygrostat
  - entity: climate.hvac
  - entity: climate.heatpump
  - entity: climate.ecobee
  - entity: cover.kitchen_window
show_header_toggle: true
title: Humidifier comparison
type: entities

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett
Copy link
Contributor

I feel like this should be more similar to a Climate Row. The top section is the toggle and under the toggle Currently: 25%

@Shulyaka
Copy link
Contributor Author

We don't have the current humidity for the humidifier entity, only target.

@zsarnett
Copy link
Contributor

Okay. Then change currently to target

@bramkragten
Copy link
Member

We don't have the current humidity for the humidifier entity, only target.

I'm not familiar with humidifiers, but it sounds logical that some will provide the current humidity? As you can set a target it will know what the current is?

@Shulyaka
Copy link
Contributor Author

Shulyaka commented Jul 22, 2020

Well, it was decided that the current humidity must be a separate entity (home-assistant/architecture#310 (comment)). So the target humidity, mode and state are all we have.
I also don't think we should move the toggle because firstly it occupies the full height and secondly if we change that, and the user adds other togglable entities on the same card, it would look out of place.

@bramkragten
Copy link
Member

Do we have a reference to this separate entity? In the frontend we should still show them together I think.

@Shulyaka
Copy link
Contributor Author

They could be linked via the device registry. Is it available i frontend?
And we also need to consider a case where it is not linked.

@zsarnett
Copy link
Contributor

Lets just move the Current Humidity to the secondary info location. This will be similar to how we allow the current brightness in the secondary info. This wont be an option to choose but set via this row type. Let get this PR merged for 0.116

@Shulyaka
Copy link
Contributor Author

I am sorry but unfortunately couldn't quite get the idea.
What is the secondary info location? If you mean the "more info dialog", then it is already there as a slider even without this PR:
humidifier-more-info

@zsarnett
Copy link
Contributor

No

In the entity row.
image

@Shulyaka
Copy link
Contributor Author

I couldn't find an example how current brightness is used in the secondary info. May I ask you to point me to a right direction?)

Co-authored-by: Zack Barett <zackbarett@hey.com>
@bramkragten bramkragten merged commit 245c825 into home-assistant:dev Sep 24, 2020
@Shulyaka Shulyaka deleted the humidifier_row branch September 24, 2020 15:58
@bramkragten bramkragten mentioned this pull request Sep 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants