Skip to content

Reset path on icon change#5790

Merged
bramkragten merged 1 commit into
devfrom
reset-path
May 7, 2020
Merged

Reset path on icon change#5790
bramkragten merged 1 commit into
devfrom
reset-path

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 7, 2020

Breaking change

Proposed change

Not sure if this was on purpose or not. Without this change the previous icon shows longer when we are changing to a different MDI icon.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob requested a review from bramkragten May 7, 2020 05:49
@bramkragten bramkragten merged commit eba7ced into dev May 7, 2020
@bramkragten bramkragten deleted the reset-path branch May 7, 2020 10:37
@bramkragten bramkragten mentioned this pull request May 9, 2020
@lock lock Bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants