Skip to content

Fix removal of option in select helper #5777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 1 commit into from
May 6, 2020
Merged

Fix removal of option in select helper #5777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/panels/config/helpers/forms/ha-input_select-form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ class HaInputSelectForm extends LitElement {
}

private async _removeOption(ev: Event) {
const index = (ev.target as any).index;
if (
!(await showConfirmationDialog(this, {
title: "Delete this item?",
Expand All @@ -161,7 +162,6 @@ class HaInputSelectForm extends LitElement {
) {
return;
}
const index = (ev.target as any).index;
const options = [...this._options];
options.splice(index, 1);
fireEvent(this, "value-changed", {
Expand Down