Skip to content

make color of update-heading in primary-text-color#5754

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
basnijholt:patch-2
May 5, 2020
Merged

make color of update-heading in primary-text-color#5754
bramkragten merged 2 commits intohome-assistant:devfrom
basnijholt:patch-2

Conversation

@basnijholt
Copy link
Copy Markdown
Contributor

@basnijholt basnijholt commented May 5, 2020

This fixes basnijholt/lovelace-ios-dark-mode-theme#47.

Breaking change

Color of the update-heading div will be editteable.

Proposed change

Make it primary-text-color.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Will fix the Update available: "Home Assistant Core 0.109.3" text color.
image

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment thread hassio/src/dashboard/hassio-update.ts
Copy link
Copy Markdown
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bramkragten bramkragten merged commit d419547 into home-assistant:dev May 5, 2020
@bramkragten bramkragten mentioned this pull request May 5, 2020
@lock lock Bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with "Update Available" with HassIO >0.109

3 participants