Supervisor dialogs#5740
Merged
bramkragten merged 7 commits intohome-assistant:devfrom May 4, 2020
ludeeus:supervisor-dialog
Merged
Supervisor dialogs#5740bramkragten merged 7 commits intohome-assistant:devfrom ludeeus:supervisor-dialog
bramkragten merged 7 commits intohome-assistant:devfrom
ludeeus:supervisor-dialog
Conversation
Contributor
|
This PR also fixes #4981 |
Member
Author
|
Yes, that is a duplicate of #4915 |
Contributor
|
I know it's not within the supervisor, but since you replace the only other occurence of prompt() that's left within the frontend in this PR, maybe you could also have a look at this issue (and maybe fix it within this PR): #5741 |
Member
Author
|
Eventually, maybe, but that is out of the scope here. |
McGiverGim
suggested changes
May 3, 2020
frenck
reviewed
May 3, 2020
| .hass=${this.hass} | ||
| .path="hassio/addons/${this.addon.slug}/rebuild" | ||
| > | ||
| Rebuild |
Member
There was a problem hiding this comment.
You are a hero for moving this! 🥇
frenck
reviewed
May 3, 2020
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
bramkragten
approved these changes
May 3, 2020
| if (hostname && hostname !== curHostname) { | ||
| this.hass.callApi("POST", "hassio/host/options", { hostname }); | ||
| try { | ||
| await changeHostOptions(this.hass, { hostname }); |
Member
There was a problem hiding this comment.
Doesn't this return the new info?
Member
Author
There was a problem hiding this comment.
Not sure, I'll do some testing later today
Member
Author
There was a problem hiding this comment.
It only returns {result: "ok", data: {…}} where data is empty.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: