Skip to content

Implement add-on changelog#5727

Merged
bramkragten merged 3 commits into
home-assistant:devfrom
ludeeus:addon-changelog
May 7, 2020
Merged

Implement add-on changelog#5727
bramkragten merged 3 commits into
home-assistant:devfrom
ludeeus:addon-changelog

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 2, 2020

Breaking change

Proposed change

Adds a link to open the changelog, moves version from right to left.
Implemented based on #5709 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Installed:
image

Not installed:
image

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus changed the title WIP: Implement add-on changelog Implement add-on changelog May 3, 2020
@ludeeus ludeeus marked this pull request as ready for review May 3, 2020 14:04
Comment on lines +201 to +202
<span>(</span><span class="changelog-link">changelog</span
><span>)</span>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the spans around the ()?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To stop autoformatting on adding weird spaces.
Do you have another solution for that?

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label May 5, 2020
@bramkragten bramkragten merged commit 44ad75a into home-assistant:dev May 7, 2020
@bramkragten bramkragten mentioned this pull request May 9, 2020
@lock lock Bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Supervisor Related to the supervisor panel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add add-on changelog

3 participants