Skip to content

Don't show error on open of dialog #5721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludeeus merged 1 commit into from
May 2, 2020
Merged

Don't show error on open of dialog #5721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/panels/config/person/dialog-person-detail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ class DialogPersonDetail extends LitElement {
${this._error ? html` <div class="error">${this._error}</div> ` : ""}
<div class="form">
<paper-input
dialogInitialFocus
.value=${this._name}
@value-changed=${this._nameChanged}
label="${this.hass!.localize(
Expand All @@ -87,7 +88,8 @@ class DialogPersonDetail extends LitElement {
error-message="${this.hass!.localize(
"ui.panel.config.person.detail.name_error_msg"
)}"
.invalid=${nameInvalid}
required
auto-validate
></paper-input>
<ha-user-picker
label="${this.hass!.localize(
Expand Down
4 changes: 3 additions & 1 deletion src/panels/config/zone/dialog-zone-detail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ class DialogZoneDetail extends LitElement {
${this._error ? html` <div class="error">${this._error}</div> ` : ""}
<div class="form">
<paper-input
dialogInitialFocus
.value=${this._name}
.configValue=${"name"}
@value-changed=${this._valueChanged}
Expand All @@ -114,7 +115,8 @@ class DialogZoneDetail extends LitElement {
.errorMessage="${this.hass!.localize(
"ui.panel.config.zone.detail.required_error_msg"
)}"
.invalid=${nameValid}
required
auto-validate
></paper-input>
<paper-input
.value=${this._icon}
Expand Down