Fix cast navigation on none default dashboard#5719
Merged
Conversation
balloob
reviewed
May 3, 2020
| gulp.series( | ||
| async function setEnv() { | ||
| process.env.NODE_ENV = "development"; | ||
| process.env.IS_CAST = "true"; |
Member
There was a problem hiding this comment.
Still used in build-scripts/gulp/translations.js:279
Member
There was a problem hiding this comment.
I'm thinking now, I think that we can remove the old translations for cast now that we mix in backend. You can remove that whole hack.
balloob
approved these changes
May 3, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5613
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: