Skip to content

Add reload buttons to store and snapshot#5714

Merged
bramkragten merged 3 commits intohome-assistant:devfrom
ludeeus:supervisor-reload
May 2, 2020
Merged

Add reload buttons to store and snapshot#5714
bramkragten merged 3 commits intohome-assistant:devfrom
ludeeus:supervisor-reload

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 2, 2020

Breaking change

Proposed change

This adds back the reload button to the store and snapshot pags.
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label May 2, 2020

if (addons.length === 0) {
continue;
if (this._repos) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this in a memoizeOne


${repos}
.narrow=${this.narrow}
!hassio
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the h... did that happen....

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the ! a typo?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire line should not be there, so I don't think so

></hassio-addons>
</div>
<hass-tabs-subpage
.hass=${this.hass}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hassio

<hass-tabs-subpage
<hassio-panel-router
.route=${this.route}
.hass=${this.hass}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hassio

</div>
<hass-tabs-subpage
.hass=${this.hass}
.narrow=${this.narrow}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hassio

></hassio-host-info>
<hass-tabs-subpage
.hass=${this.hass}
.narrow=${this.narrow}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hassio

@bramkragten bramkragten merged commit 79d1a2f into home-assistant:dev May 2, 2020
@bramkragten bramkragten mentioned this pull request May 5, 2020
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Supervisor Related to the supervisor panel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Refesh or reload snapshot button in 0.109.2

3 participants