Skip to content

Supervisor style changes#5706

Merged
bramkragten merged 5 commits intohome-assistant:devfrom
ludeeus:supervisor-style
May 2, 2020
Merged

Supervisor style changes#5706
bramkragten merged 5 commits intohome-assistant:devfrom
ludeeus:supervisor-style

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented May 2, 2020

Breaking change

Proposed change

  • Style changes for darker themes.
  • Adds addon name in log/config card in case you forgot which addon you are inspecting 🤷
  • Removes spinner for log, this was confusing when the addon was not started.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label May 2, 2020

return html`
<paper-card heading="Config">
<paper-card heading="${this.addon.name} Configuration">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add it as a title/heading above each page?

Instead of adding it to the title of the card.
Some add-on names might long?

This also makes it inconsistent right now with the network card. I guess we could add it there too, but that would become ugly?

@bramkragten bramkragten merged commit f16a674 into home-assistant:dev May 2, 2020
@bramkragten bramkragten mentioned this pull request May 5, 2020
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Supervisor Related to the supervisor panel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supervisor - place the add-on name into card headings Some theme colors don’t match anymore with supervisor 220

4 participants