Adds stage badge#5685
Merged
bramkragten merged 4 commits intohome-assistant:devfrom May 1, 2020
ludeeus:addon-info-stage
Merged
Adds stage badge#5685bramkragten merged 4 commits intohome-assistant:devfrom ludeeus:addon-info-stage
bramkragten merged 4 commits intohome-assistant:devfrom
ludeeus:addon-info-stage
Conversation
frenck
reviewed
May 1, 2020
| ` | ||
| : ""} | ||
| <div class="security"> | ||
| <ha-label-badge |
Member
There was a problem hiding this comment.
I still think we should iconize it... 🤷♂️
As the text will never fit in the badge itself.
Member
Author
There was a problem hiding this comment.
Sure, we can do that, but I think that will be confusing.
I'll throw up some examples in a few mins.
Member
Author
There was a problem hiding this comment.
If they are added to the dialog as well, that might work:
Member
There was a problem hiding this comment.
I like that approach by including the mapping in the description!
Member
There was a problem hiding this comment.
Maybe we only have to show this if it isn't stable?
Member
Author
There was a problem hiding this comment.
I think they always should show, regardless of the stage.
pvizeli
approved these changes
May 1, 2020
bramkragten
reviewed
May 1, 2020
bramkragten
reviewed
May 1, 2020
bramkragten
reviewed
May 1, 2020
| auto_uart: boolean; | ||
| icon: boolean; | ||
| logo: boolean; | ||
| stage?: string; |
Member
There was a problem hiding this comment.
Suggested change
| stage?: string; | |
| stage: "stable" | "experimental" | "deprecated"; |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Adds a new stage bage to the addon info tab to show what stage the addon is in.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: