Skip to content

Improved spacing balance for weather forecast#5673

Merged
bramkragten merged 2 commits intohome-assistant:devfrom
pedrolamas:plamas/weather-forecast-spacing
Apr 30, 2020
Merged

Improved spacing balance for weather forecast#5673
bramkragten merged 2 commits intohome-assistant:devfrom
pedrolamas:plamas/weather-forecast-spacing

Conversation

@pedrolamas
Copy link
Copy Markdown
Contributor

Proposed change

Improves the visual balance on the forecast item spacing on the weather card.

The only change here is to ensure that items have spacing around them, and not just between them, thus making them look better, more balanced, and more inline with what is in use for the Glance Card.

Before:

image

After:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett
Copy link
Copy Markdown
Contributor

:host([narrow]) .forecast {
justify-content: space-around;
}

Remove this as its no longer need with this change

@pedrolamas
Copy link
Copy Markdown
Contributor Author

@zsarnett block removed as requested!

@bramkragten bramkragten merged commit f471089 into home-assistant:dev Apr 30, 2020
@pedrolamas pedrolamas deleted the plamas/weather-forecast-spacing branch April 30, 2020 17:57
@bramkragten bramkragten mentioned this pull request May 5, 2020
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants