Skip to content

Exclude esprima and drop js-yaml from lovelace chunk#5649

Merged
bramkragten merged 3 commits intodevfrom
optimize-js-yaml
Apr 30, 2020
Merged

Exclude esprima and drop js-yaml from lovelace chunk#5649
bramkragten merged 3 commits intodevfrom
optimize-js-yaml

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Proposed change

We don't need esprima, it is just used in js-yaml for !!js/function.
js-yaml was included in the Lovelace chunk because the error-card used it, it is now dynamically imported.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob
Copy link
Copy Markdown
Member

balloob commented Apr 28, 2020

Why is the error card included in base Lovelace? We should load it on demand.

@bramkragten bramkragten merged commit f3e88f6 into dev Apr 30, 2020
@bramkragten bramkragten deleted the optimize-js-yaml branch April 30, 2020 18:39
@bramkragten bramkragten mentioned this pull request May 5, 2020
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants