Group config entries by integration#5646
Merged
bramkragten merged 5 commits intodevfrom Apr 30, 2020
Merged
Conversation
balloob
reviewed
Apr 28, 2020
balloob
reviewed
Apr 28, 2020
balloob
reviewed
Apr 28, 2020
balloob
reviewed
Apr 28, 2020
Comment on lines
+70
to
+73
| return this._renderSingleEntry(configEntry); | ||
| } | ||
| } | ||
| return this._renderGroupedIntegration(); |
Member
There was a problem hiding this comment.
Should we make this 2 webcomponents or are you doing this because you have a transition between a list and a specific integration ?
Member
Author
There was a problem hiding this comment.
Then it would be 3, 1 for keeping the state and 2 for rendering grouped/single.
Member
There was a problem hiding this comment.
I think that would be better ? I dunno.
balloob
approved these changes
Apr 29, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: