Translation fixes#5634
Merged
bramkragten merged 6 commits intodevfrom Apr 26, 2020
Merged
Conversation
20 tasks
bramkragten
approved these changes
Apr 26, 2020
c069976 to
ba18491
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
So I realized that sprinkling the code with
__BACKWARDS_COMPAT__wherever we load translations of states is going to get old really fast and we'll probably miss ones.So instead I went the other way around: for builds that do not have access to the backend or that will potentially connect to older backends (cast), we merge in a copy of the backend state translations.
Backend translations are created using a new addition to the core repo translations script.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: