Skip to content

Weather Card: Switch Importance of Name and State#5624

Merged
zsarnett merged 2 commits intohome-assistant:devfrom
zsarnett:weather-card-improvements
Apr 27, 2020
Merged

Weather Card: Switch Importance of Name and State#5624
zsarnett merged 2 commits intohome-assistant:devfrom
zsarnett:weather-card-improvements

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett commented Apr 24, 2020

Breaking change

Proposed change

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Copy Markdown
Member

Can we align the text sizes in the header? So we only use 2 font sizes

@zsarnett
Copy link
Copy Markdown
Contributor Author

zsarnett commented Apr 25, 2020

Because the name can be much longer than the temp. I don't think it looks good. Takes away from the temp

@zsarnett
Copy link
Copy Markdown
Contributor Author

Wondering if the High and low labels are needed if they are both present. Example

63°F / 54°F
High 63°F
Low 54°F

@bramkragten
Copy link
Copy Markdown
Member

Would leave them out we also don't have them on the forecast

@zsarnett
Copy link
Copy Markdown
Contributor Author

I have an Idea for this going to work on it tomorrow. Still can't get my dev env up as HA on Windows is booty. And I cant use docker and dual boot sounds like too much work :)

@zsarnett
Copy link
Copy Markdown
Contributor Author

Went with the suggestion from Bram. Two Font sizes in the Header

467633f77666348d3c023576df71f80a

@zsarnett zsarnett added this to the 0.109.0 milestone Apr 27, 2020
@zsarnett zsarnett merged commit 75ba343 into home-assistant:dev Apr 27, 2020
@zsarnett zsarnett deleted the weather-card-improvements branch April 27, 2020 18:43
bramkragten pushed a commit that referenced this pull request Apr 28, 2020
* Improvements to the name and state importance

* Bram Suggestions
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants