Skip to content

Add up/down movement icons to shutter#5579

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
nagyrobi:patch-1
Apr 21, 2020
Merged

Add up/down movement icons to shutter#5579
bramkragten merged 1 commit intohome-assistant:devfrom
nagyrobi:patch-1

Conversation

@nagyrobi
Copy link
Copy Markdown
Contributor

@nagyrobi nagyrobi commented Apr 20, 2020

Breaking change

No.

Proposed change

Since window shutters are also moving up and down, add these icons for during movement.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

None.

Additional information

None.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

Since window shutters are also moving up and down, add these icons for during movement.
@homeassistant
Copy link
Copy Markdown
Contributor

Hi @nagyrobi,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@bramkragten bramkragten merged commit 8786302 into home-assistant:dev Apr 21, 2020
@bramkragten bramkragten mentioned this pull request Apr 22, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants