Conversation
balloob
approved these changes
Apr 14, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
ts-lit-pluginandlit-analyzer.If you have the vs code lit-plugin installed, it will give you type checking, autocomplete and checks of lit HTML templates.
You can also run
yarn run lint:litto get a list of all the issues (a lot right now)We don't enforce these rules now, but by making them visible we hope we can work towards enforcing them in the future by fixing things step by step.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: