Skip to content

Update typescript, prettier, tslint -> eslint#5536

Merged
balloob merged 3 commits intodevfrom
lint
Apr 14, 2020
Merged

Update typescript, prettier, tslint -> eslint#5536
balloob merged 3 commits intodevfrom
lint

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Proposed change

Updated typescript to 3.8

Using import type now

Updated babel, eslint and prettier to handle that.

Migrated tslint to eslint.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@iantrich
Copy link
Copy Markdown
Member

...wow...

@bramkragten
Copy link
Copy Markdown
Member Author

Git didn't allowed me to change the github action in the PR. Not sure if/how the test here should be fixed.

@ludeeus
Copy link
Copy Markdown
Member

ludeeus commented Apr 14, 2020

Should not be an issue, I have done that multiple times.
Worst case, you could try using GitHub's UI to change it?

@balloob balloob merged commit 82f80db into dev Apr 14, 2020
@balloob balloob deleted the lint branch April 14, 2020 16:05
@bramkragten bramkragten mentioned this pull request Apr 14, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants