Skip to content

Remove srcset from brands#5517

Merged
bramkragten merged 1 commit intodevfrom
remove-srcset-brands
Apr 15, 2020
Merged

Remove srcset from brands#5517
bramkragten merged 1 commit intodevfrom
remove-srcset-brands

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 10, 2020

Breaking change

Proposed change

Minimum icon size is 256x256. Each location that we use icons is less than half of that, so we don't need to define srcset.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit ed54a18 into dev Apr 15, 2020
@bramkragten bramkragten deleted the remove-srcset-brands branch April 15, 2020 14:00
@lock lock Bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants