Skip to content

Add icons when adding integration#5500

Merged
bramkragten merged 2 commits intodevfrom
add-integration-icon
Apr 9, 2020
Merged

Add icons when adding integration#5500
bramkragten merged 2 commits intodevfrom
add-integration-icon

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 8, 2020

Breaking change

Proposed change

So I went to add pictures to the add integration screen.

Realized that the search input had margin built-in, which was weird, and also took that one out and added it back everywhere it was used.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@frenck
Copy link
Copy Markdown
Member

frenck commented Apr 8, 2020

Use the URL without the underscore, because it is now falling back to placeholders

@balloob
Copy link
Copy Markdown
Member Author

balloob commented Apr 8, 2020

That was on purpose :)

@bramkragten bramkragten merged commit cb255ef into dev Apr 9, 2020
@bramkragten bramkragten deleted the add-integration-icon branch April 9, 2020 12:44
@bramkragten bramkragten mentioned this pull request Apr 14, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants