Skip to content

Graph Footer: Cache State History#5499

Merged
bramkragten merged 6 commits intohome-assistant:devfrom
zsarnett:graph-cache
Apr 22, 2020
Merged

Graph Footer: Cache State History#5499
bramkragten merged 6 commits intohome-assistant:devfrom
zsarnett:graph-cache

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett commented Apr 8, 2020

Proposed change

Cache the state history of the entity and only fetch from the last update until the time of the new update.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Comment thread src/panels/lovelace/header-footer/hui-graph-header-footer.ts
Comment thread src/panels/lovelace/header-footer/hui-graph-header-footer.ts Outdated
Comment thread src/panels/lovelace/header-footer/hui-graph-header-footer.ts
@bramkragten
Copy link
Copy Markdown
Member

This

43dc43d#diff-4617a1a8ea3c2e00061a4a28c739de4fR98

Should be inside the check on line 95

@zsarnett
Copy link
Copy Markdown
Contributor Author

I will resolve these today. and merge

@zsarnett
Copy link
Copy Markdown
Contributor Author

This

43dc43d#diff-4617a1a8ea3c2e00061a4a28c739de4fR98

Should be inside the check on line 95

@bramkragten I am not 100% what you mean by this. Guessing you are talking about the this._fetching but not sure

@bramkragten
Copy link
Copy Markdown
Member

bramkragten commented Apr 21, 2020

This
43dc43d#diff-4617a1a8ea3c2e00061a4a28c739de4fR98
Should be inside the check on line 95

@bramkragten I am not 100% what you mean by this. Guessing you are talking about the this._fetching but not sure

Line 98 should be in the if check after line 95

image

EDIT:
Never mind, my eyes are crap.

@bramkragten bramkragten merged commit 1c1f9a6 into home-assistant:dev Apr 22, 2020
@bramkragten bramkragten mentioned this pull request Apr 22, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants