Skip to content

Adds more log types to the system tab#5496

Merged
pvizeli merged 11 commits intohome-assistant:devfrom
ludeeus:more-supervisor-logs
Apr 29, 2020
Merged

Adds more log types to the system tab#5496
pvizeli merged 11 commits intohome-assistant:devfrom
ludeeus:more-supervisor-logs

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Apr 8, 2020

Proposed change

Adds logs for:

  • Host
  • DNS
  • Audio
  • Multicast

This will only show if it's an advanced user looking at it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

2020-04-08_22-26-24

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label Apr 8, 2020
@bramkragten
Copy link
Copy Markdown
Member

Should we add a loading screen or clear the screen when you switch sources?

@bramkragten
Copy link
Copy Markdown
Member

And maybe we should move the dropdown to the bottom? As I think most users won't need it?

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Apr 15, 2020

Should we add a loading screen or clear the screen when you switch sources?

Sure, I can add a loader there, if I can get my env working again after your recent changes.....

Adding it to the bottom just feels wrong, if you need host logs, you load the page, scroll to the bottom, change it to host, then scroll up to start reading?
How about hiding it if not advanced user instead?

@bramkragten
Copy link
Copy Markdown
Member

True, let's hide it for none expert user

@ludeeus ludeeus requested a review from bramkragten April 15, 2020 18:33
Comment thread hassio/src/system/hassio-supervisor-log.ts Outdated
Comment thread hassio/src/system/hassio-supervisor-log.ts Outdated
ludeeus and others added 2 commits April 16, 2020 12:19
Co-Authored-By: Bram Kragten <mail@bramkragten.nl>
@ludeeus ludeeus requested a review from bramkragten April 16, 2020 13:14
Comment thread hassio/src/system/hassio-supervisor-log.ts
Comment thread hassio/src/components/hassio-ansi-to-html.ts Outdated
@pvizeli pvizeli merged commit 8029c3d into home-assistant:dev Apr 29, 2020
@bramkragten bramkragten mentioned this pull request May 5, 2020
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Supervisor Related to the supervisor panel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants