Skip to content

Use hass-tabs-subpage in add-on view#5483

Merged
bramkragten merged 17 commits intohome-assistant:devfrom
ludeeus:addon-tabs
May 1, 2020
Merged

Use hass-tabs-subpage in add-on view#5483
bramkragten merged 17 commits intohome-assistant:devfrom
ludeeus:addon-tabs

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Apr 7, 2020

Proposed change

Change add-on view to be tab based (by using hass-tabs-subpage), this will make room for the documentation endpoint in the backend.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • ? New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

2020-04-07_17-12-32

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the Supervisor Related to the supervisor panel label Apr 7, 2020
@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Apr 29, 2020

Any news on that? I would otherwise create a new branch "supervisor" we merge this into that so we can play within on RL.

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Apr 29, 2020

Didn't notice there were conflicts here.
I'll look at those tomorrow

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Apr 30, 2020

Should be a good branch again now

Comment thread hassio/src/addon-view/hassio-addon-router.ts Outdated
Comment thread hassio/src/addon-view/info/hassio-addon-info-tab.ts Outdated
Comment thread hassio/src/addon-view/info/hassio-addon-info.ts Outdated
Comment thread hassio/src/addon-view/info/hassio-addon-info-tab.ts Outdated
Comment thread hassio/src/addon-view/config/hassio-addon-config-tab.ts Outdated
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@bramkragten bramkragten merged commit 6847830 into home-assistant:dev May 1, 2020
@bramkragten bramkragten mentioned this pull request May 5, 2020
@lock lock Bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed Supervisor Related to the supervisor panel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants