Skip to content

Preview badge: Margin#5424

Merged
zsarnett merged 1 commit intohome-assistant:devfrom
zsarnett:preview-badge-margin
Apr 2, 2020
Merged

Preview badge: Margin#5424
zsarnett merged 1 commit intohome-assistant:devfrom
zsarnett:preview-badge-margin

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett commented Apr 2, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett zsarnett linked an issue Apr 2, 2020 that may be closed by this pull request
display: flex;
justify-content: center;
margin: 8px 16px;
margin: 12px 16px;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same as on the Lovelace view?

Copy link
Copy Markdown
Contributor Author

@zsarnett zsarnett Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has the 4 px padding around the top of the view. Plus the 8px 16px margin

@zsarnett zsarnett force-pushed the preview-badge-margin branch from 422c4a0 to 306b664 Compare April 2, 2020 21:36
@zsarnett zsarnett merged commit f5d834d into home-assistant:dev Apr 2, 2020
@zsarnett zsarnett deleted the preview-badge-margin branch April 2, 2020 21:51
@bramkragten bramkragten mentioned this pull request Apr 3, 2020
@lock lock bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase spacing of Lovelace badge previews

3 participants