Skip to content

Delete Card Action: Undo in Toast#5405

Merged
bramkragten merged 5 commits intohome-assistant:devfrom
zsarnett:delete-toast-undo
Apr 2, 2020
Merged

Delete Card Action: Undo in Toast#5405
bramkragten merged 5 commits intohome-assistant:devfrom
zsarnett:delete-toast-undo

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett commented Apr 2, 2020

Proposed change

Adds Undo action to Delete Card

Also Updates Toast Styling

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@zsarnett
Copy link
Copy Markdown
Contributor Author

zsarnett commented Apr 2, 2020

Partly fixes #4094

export const showDeleteSuccessToast = (
el: HTMLElement,
hass: HomeAssistant,
action: () => void
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be optional

@bramkragten bramkragten merged commit 0f2eae4 into home-assistant:dev Apr 2, 2020
@bramkragten bramkragten mentioned this pull request Apr 3, 2020
@lock lock bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants