Footer/Header: Graph#5273
Merged
Merged
Conversation
Contributor
Author
Error if not a sensor entity
Warning if not numeric
Should these be changed? |
bramkragten
reviewed
Mar 21, 2020
|
|
||
| const stateObj = this.hass!.states[this._config.entity]; | ||
|
|
||
| if (!stateObj.attributes.unit_of_measurement) { |
Member
There was a problem hiding this comment.
Why do we need a unit_of_measurement for a line graph?
Contributor
Author
There was a problem hiding this comment.
No 100% sure. That's how we built it back when we built the sensor card. I tried a sensor with no UOM and received an error. but the state was also not a number.
Added in a catch for if the state history is undefined. That should catch this.
bramkragten
reviewed
Mar 21, 2020
bramkragten
reviewed
Mar 21, 2020
bramkragten
approved these changes
Mar 21, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds the graph from the sensor card as a Footer Header Option
Type of change
Example configuration
Checklist
If user exposed functionality or configuration variables are added/changed:
home-assistant/home-assistant.io#12492