Extract media controls into method#5141
Merged
Merged
Conversation
zsarnett
reviewed
Mar 12, 2020
zsarnett
reviewed
Mar 12, 2020
zsarnett
reviewed
Mar 12, 2020
Contributor
|
Idle is still Grayscale |
zsarnett
reviewed
Mar 12, 2020
| `} | ||
| </div> | ||
| `} | ||
| <div class="playback-controls"> |
Contributor
There was a problem hiding this comment.
Update the CSS class to be .playback-controls or change this back to .controls
zsarnett
reviewed
Mar 12, 2020
Member
Author
|
Updated |
Member
Author
|
|
zsarnett
approved these changes
Mar 12, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Extract button generation into a new method to make it easier to follow what's going on.
Update gallery to show more relevant states.
If player is idle and it supports play, show play button.
Check for existence of "media_position" instead of truthy check, as we were not showing progress bars if media position was 0.
Updated gallery:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: