Skip to content

Add Descriptions for cards - Card Picker#5058

Merged
zsarnett merged 6 commits into
home-assistant:devfrom
zsarnett:card-descriptions
Mar 3, 2020
Merged

Add Descriptions for cards - Card Picker#5058
zsarnett merged 6 commits into
home-assistant:devfrom
zsarnett:card-descriptions

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett commented Mar 3, 2020

Proposed change

Adds in Descriptions for the other cards in case entities can not be found

Comment thread src/translations/en.json Outdated
Comment thread src/translations/en.json Outdated
Comment thread src/translations/en.json
Comment thread src/translations/en.json Outdated
Comment thread src/translations/en.json Outdated
Comment thread src/translations/en.json Outdated
Comment thread src/translations/en.json Outdated
Comment thread src/translations/en.json Outdated
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 3, 2020

This is going to help a lot (love this card picker feature)! Nevertheless, left some comments where I think it can be improved.

Consistency (capitalization of card names, mentioning card names or not) is maybe the main point I have.

Another I would like to address (but didn't above), is the use of 'very simple' in quite a view cases. I think it isn't fitting. It could be "not simple" for other people? Maybe a term like "basic" or "elementary" fits better.

@zsarnett
Copy link
Copy Markdown
Contributor Author

zsarnett commented Mar 3, 2020

@frenck I agree with you in all these. I have updated most of the descriptions now following a few of your points. They now each say The [Name of card] card. I have removed Very Simple cases and references to old UI. Updated a few words choices and long descriptions that didn't make sense.

@zsarnett zsarnett requested a review from frenck March 3, 2020 21:09
Comment thread src/translations/en.json Outdated
Comment thread src/translations/en.json Outdated
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 3, 2020

✅ Fine by me!

Again, love this feature. Well done sir! 🎉

@zsarnett zsarnett merged commit c6f101a into home-assistant:dev Mar 3, 2020
@zsarnett zsarnett deleted the card-descriptions branch March 3, 2020 22:05
@lock lock Bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants