Skip to content

Fix multiselect without data #4906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 1 commit into from
Feb 18, 2020
Merged

Fix multiselect without data #4906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/components/ha-form/ha-form-multi_select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export class HaFormMultiSelect extends LitElement implements HaFormElement {
? this.schema.options
: Object.entries(this.schema.options!);

const data = this.data || [];
return html`
<paper-menu-button horizontal-align="right" vertical-offset="8">
<div class="dropdown-trigger" slot="dropdown-trigger">
Expand All @@ -49,7 +50,7 @@ export class HaFormMultiSelect extends LitElement implements HaFormElement {
id="input"
type="text"
readonly
value=${this.data
value=${data
.map((value) => this.schema.options![value] || value)
.join(", ")}
label=${this.label}
Expand All @@ -68,7 +69,7 @@ export class HaFormMultiSelect extends LitElement implements HaFormElement {
multi
slot="dropdown-content"
attr-for-selected="item-value"
.selectedValues=${this.data}
.selectedValues=${data}
@selected-items-changed=${this._valueChanged}
@iron-select=${this._onSelect}
>
Expand All @@ -79,7 +80,7 @@ export class HaFormMultiSelect extends LitElement implements HaFormElement {
return html`
<paper-icon-item .itemValue=${value}>
<paper-checkbox
.checked=${this.data.includes(value)}
.checked=${data.includes(value)}
slot="item-icon"
></paper-checkbox>
${this._optionLabel(item)}
Expand Down