Skip to content

Less whitespace around icon#4888

Merged
balloob merged 1 commit into
devfrom
sensor-icon-padding
Feb 16, 2020
Merged

Less whitespace around icon#4888
balloob merged 1 commit into
devfrom
sensor-icon-padding

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 16, 2020

Breaking change

Proposed change

Make the icon on the sensor card be as far away to the right inside the div as possible. That way the 16px margin on the container div ensures name and icon are both equal distance to their respective edges.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit f4eb338 into dev Feb 16, 2020
@delete-merged-branch delete-merged-branch Bot deleted the sensor-icon-padding branch February 16, 2020 06:39
@lock lock Bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants