add create helper functions for custom cards#4853
Merged
Merged
Conversation
bramkragten
reviewed
Feb 12, 2020
thomasloven
approved these changes
Feb 13, 2020
Contributor
thomasloven
left a comment
There was a problem hiding this comment.
I like how this is not polluting window like anything I would have come up with.
Agree with Bram about deferred exports. That's a neat feature.
9 tasks
Member
Author
|
thoughts on exposing action handler? That's another thing that keeps changing |
Member
|
Makes sense I think. But let's discuss it in a new PR and get this merged so we can do a dev UI release so people can start testing their custom cards against it . |
Member
|
Does this PR already have documentation? |
Member
Author
|
No |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Exposing the create helpers functions so that custom cards can use them. Will add this to the dev docs as they are added.
Type of change
Example configuration
Simple custom card implementation to use it
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: