Skip to content

[logbook] fix margins for RTL languages#4852

Merged
balloob merged 1 commit into
home-assistant:devfrom
KapJI:logbook-rtl-margins
Feb 12, 2020
Merged

[logbook] fix margins for RTL languages#4852
balloob merged 1 commit into
home-assistant:devfrom
KapJI:logbook-rtl-margins

Conversation

@KapJI
Copy link
Copy Markdown
Member

@KapJI KapJI commented Feb 12, 2020

Proposed change

For RTL languages these margins should be from the opposite side.

Before:
Screen Shot 2020-02-12 at 12 00 11 AM

After:
Screen Shot 2020-02-12 at 12 04 36 AM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit a952902 into home-assistant:dev Feb 12, 2020
@bramkragten bramkragten mentioned this pull request Feb 12, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants