Update Media Card to check for Supported Features#4850
Conversation
|
Still some big differences, mainly:
|
Fixed. Disabled when the state is
Fixed. Play button is no longer rendered and the image is darkened when the state is
This is something I changed to be consistent with the card size. I have made it so all the albums are the same size if the card is playing
I disagree with the progress bar being removed if the state is
Fixed. Height is animated when the image is changed
Fixed. This was changed the be
Fixed. Media Title is not set to show ellipsis when longer than one row of text |
|
@balloob The demo (Arsaboo) has the image pulling from api folder. The new system tries to find that and convert to base64 but for that image, in particular, it isn't found. Resulting in a blue background |
|
I don't understand, we shouldn't try to fetch the image unless there is one? Also why are we converting it to base64? It's already a url. If it needs auth we should use a signed url. |
|
The reason the image shows up blank before the recent change was that an entity image was supplied "api/.../image" URL. But that URL was not found and no image was returned. The previous way doesn't check to see if that image exists or not. We are only converting to base64 if the image is a local image. |
|
#4489 Also Adding this here as something that may need to be checked for. Will use this PR to update |
| return; | ||
| } | ||
|
|
||
| fetchMediaPlayerThumbnailWithCache(this.hass, this._config.entity).then( |
There was a problem hiding this comment.
@balloob didn't we move the thumbnails away from the ws?
There was a problem hiding this comment.
What is the status on how we should fetch the image? Should it be reverted to using the image URL or is this the best method. This is the method it was using before the conversion.
|
Fixes: #4503 |




Type of change
Bugfix (non-breaking change which fixes an issue)
Code quality improvements to existing code or addition of tests
This PR fixes or closes issue: fixes Media player card doesn't check supported features #4844
Checklist