Skip to content

[logbook] configure flex container to display entries correctly on mobile devices#4810

Merged
bramkragten merged 1 commit into
home-assistant:devfrom
KapJI:logbook-mobile
Feb 10, 2020
Merged

[logbook] configure flex container to display entries correctly on mobile devices#4810
bramkragten merged 1 commit into
home-assistant:devfrom
KapJI:logbook-mobile

Conversation

@KapJI
Copy link
Copy Markdown
Member

@KapJI KapJI commented Feb 8, 2020

Proposed change

After adding seconds in logbook I noticed that log entries don't look right from the mobile browser. This happens when entry message doesn't fit one line. Then flex container tries to shrink time and icon which looks bad. This change protects width of these elements so only message itself can be shrank.

Before:
Screen Shot 2020-02-08 at 10 30 39 PM
After:
Screen Shot 2020-02-08 at 10 31 35 PM

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 4613d8b into home-assistant:dev Feb 10, 2020
@bramkragten bramkragten mentioned this pull request Feb 12, 2020
@lock lock Bot locked and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants