Add seconds to some UI elements#4765
Conversation
|
No. Your description focuses on the logbook but your code changes it everywhere in the app. That won't be accepted. |
|
@balloob I know that it changes it everywhere and I think there is a significant value in doing so. For example, on entity cards you will be able to see the exact time when the state changed. Can you please let me know what are your suggestions here? Do this just for a logbook? Just don't show users this information which is available and can be very useful? Change how it will appear? |
|
I agree that seconds are important, but I think that we should make sure that we know exactly all places that are impacted. For example, I think that sensors with the timestamp device class are also impacted, and I don't think that those might not need seconds. |
|
@balloob I updated PR to take much safer approach and add seconds only to few most important elements. Let me know what you think of this version. |
|
|
@balloob Thank you for reviewing this! Please let me give you some piece of feedback from the stranger. I find your initial reply here not very nice. Developers from all over the world are trying to make your project a tiny bit better and they'd probably expect feedback about their contributions like "Thanks, but there are some things you need to consider..." rather than "No. This won't be accepted.". One man wrote on his twitter profile that it's important to be nice. So please be nice and don't become Linus. I really love your project and promote it within my friends so keep doing the great things 🙂 |
Breaking change
UI will look slightly differently to users but it shouldn't affect anything.
Proposed change
Modern smart home should be fast and responsive. This means it should operate seconds or milliseconds but not minutes. Add new time formats with seconds to display time more precisely in the UI.
And use these new time formats to add seconds to 4 UI elements:
This was requested by some other users as well: https://community.home-assistant.io/t/show-seconds-in-logbook/108019
Type of change
Example configuration
No configuration needed.
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: